Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): cleanup test code #4778

Merged
merged 1 commit into from
Nov 7, 2018
Merged

Conversation

ludmilanesvitiy
Copy link
Contributor

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@codecov
Copy link

codecov bot commented Nov 6, 2018

Codecov Report

Merging #4778 into development will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4778      +/-   ##
===============================================
+ Coverage        74.31%   74.34%   +0.02%     
===============================================
  Files              202      202              
  Lines             7102     7102              
  Branches          1447     1447              
===============================================
+ Hits              5278     5280       +2     
+ Misses            1429     1425       -4     
- Partials           395      397       +2
Impacted Files Coverage Δ
src/typeahead/typeahead.directive.ts 72.77% <0%> (+1.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5a22a4...b12d3ba. Read the comment docs.

@valorkin valorkin merged commit 9f2ec92 into development Nov 7, 2018
@delete-merged-branch delete-merged-branch bot deleted the fix-cleanup-test-code branch November 7, 2018 11:18
@ghost ghost removed the needs review label Nov 7, 2018
leo6104 pushed a commit to leo6104/ngx-bootstrap that referenced this pull request Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants