Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datepicker): added Lithuanian locale support for datepicker #4787

Merged
merged 5 commits into from
Nov 15, 2018

Conversation

kiloPause
Copy link
Contributor

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@ghost ghost added the needs review label Nov 7, 2018
@codecov
Copy link

codecov bot commented Nov 7, 2018

Codecov Report

Merging #4787 into development will decrease coverage by <.01%.
The diff coverage is 72.22%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4787      +/-   ##
===============================================
- Coverage        74.46%   74.45%   -0.01%     
===============================================
  Files              203      204       +1     
  Lines             7150     7168      +18     
  Branches          1448     1457       +9     
===============================================
+ Hits              5324     5337      +13     
- Misses            1430     1432       +2     
- Partials           396      399       +3
Impacted Files Coverage Δ
src/chronos/public_api.ts 100% <100%> (ø) ⬆️
src/chronos/i18n/lt.ts 70.58% <70.58%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50507e4...ad70b5e. Read the comment docs.

Mantas-OAG
Mantas-OAG previously approved these changes Nov 11, 2018
Domainv
Domainv previously approved these changes Nov 14, 2018
@ludmilanesvitiy
Copy link
Contributor

Tested Datepicker demo with the new locale in Chrome, FF. Looks good. Tests passed, build success.

valorkin
valorkin previously approved these changes Nov 15, 2018
@Domainv Domainv dismissed stale reviews from valorkin, Mantas-OAG, and themself via ad70b5e November 15, 2018 18:59
@valorkin valorkin merged commit 87e3751 into valor-software:development Nov 15, 2018
@ghost ghost removed the ready for merge label Nov 15, 2018
leo6104 pushed a commit to leo6104/ngx-bootstrap that referenced this pull request Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants