Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): add workaround for buildOptimizer issue #4799

Merged
merged 5 commits into from
Nov 15, 2018
Merged

fix(build): add workaround for buildOptimizer issue #4799

merged 5 commits into from
Nov 15, 2018

Conversation

Domainv
Copy link
Contributor

@Domainv Domainv commented Nov 14, 2018 •
edited
Loading

Closes #4752

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@ghost ghost assigned Domainv Nov 14, 2018
@ghost ghost added the needs review label Nov 14, 2018
@Domainv Domainv changed the title fix(build): add workaround for buildOptimizer issue WIP fix(build): add workaround for buildOptimizer issue Nov 14, 2018
@codecov
Copy link

codecov bot commented Nov 14, 2018 •
edited
Loading

Codecov Report

Merging #4799 into development will increase coverage by 0.17%.
The diff coverage is 99.18%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4799      +/-   ##
===============================================
+ Coverage        74.28%   74.45%   +0.17%     
===============================================
  Files              202      202              
  Lines             7100     7148      +48     
  Branches          1447     1448       +1     
===============================================
+ Hits              5274     5322      +48     
  Misses            1430     1430              
  Partials           396      396
Impacted Files Coverage Δ
src/chronos/units/minute.ts 100% <100%> (ø) ⬆️
src/chronos/units/millisecond.ts 100% <100%> (ø) ⬆️
src/chronos/units/offset.ts 77.9% <100%> (+0.25%) ⬆️
src/chronos/locale/locales.ts 75.18% <100%> (+7.87%) ⬆️
src/chronos/units/week-year.ts 92.53% <100%> (+0.11%) ⬆️
src/chronos/format/format.ts 96.77% <100%> (ø) ⬆️
src/chronos/units/year.ts 100% <100%> (ø) ⬆️
src/chronos/units/timezone.ts 100% <100%> (ø) ⬆️
src/chronos/units/second.ts 100% <100%> (ø) ⬆️
src/chronos/units/quarter.ts 95.45% <100%> (+0.21%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d01c533...693439c. Read the comment docs.

@Domainv Domainv removed the WIP label Nov 15, 2018
@Domainv Domainv changed the title WIP fix(build): add workaround for buildOptimizer issue fix(build): add workaround for buildOptimizer issue Nov 15, 2018
@ludmilanesvitiy
Copy link
Contributor

Datepicker's demo tested in Chrome, FF - looks good. Build - ok, tests - passed.

valorkin
valorkin previously approved these changes Nov 15, 2018
View reviewed changes
@valorkin valorkin merged commit 50507e4 into development Nov 15, 2018
@delete-merged-branch delete-merged-branch bot deleted the fix-build-optimizer-chronos branch November 15, 2018 17:43
@ghost ghost removed the ready for merge label Nov 15, 2018
leo6104 pushed a commit to leo6104/ngx-bootstrap that referenced this pull request Oct 10, 2019
@Domainv @leo6104
fix(build): add workaround for buildOptimizer issue (valor-software#4799
f04c936 
)

* fix(build): add workaround for buildOptimizer issue

* fix(build): clean up

* fix(build): return logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valorkin valorkin valorkin approved these changes

Assignees

@Domainv Domainv

Labels
comp(build)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Domainv @ludmilanesvitiy @valorkin