Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datepicker): remove important properties for styles #4939

Merged
merged 1 commit into from
Dec 17, 2018
Merged

fix(datepicker): remove important properties for styles #4939

merged 1 commit into from
Dec 17, 2018

Conversation

daniloff200
Copy link
Contributor

@daniloff200 daniloff200 commented Dec 14, 2018

This PR removes important css properties from classes in datepicker styles

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@ghost ghost added the needs review label Dec 14, 2018
@Domainv Domainv changed the title fix(core): remove important properties for styles fix(datepicker): remove important properties for styles Dec 14, 2018
@codecov
Copy link

codecov bot commented Dec 14, 2018

Codecov Report

Merging #4939 into development will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           development   #4939      +/-   ##
==============================================
- Coverage        74.81%   74.8%   -0.02%     
==============================================
  Files              276     276              
  Lines             8425    8425              
  Branches          1601    1601              
==============================================
- Hits              6303    6302       -1     
- Misses            1676    1677       +1     
  Partials           446     446
Impacted Files Coverage Δ
src/chronos/i18n/pl.ts 69.23% <0%> (-2.57%) ⬇️
src/chronos/i18n/cs.ts 84.74% <0%> (ø) ⬆️
src/chronos/i18n/sk.ts 80.85% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ee6eac...5e8db2c. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 14, 2018

Codecov Report

Merging #4939 into development will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           development   #4939      +/-   ##
==============================================
- Coverage        74.81%   74.8%   -0.02%     
==============================================
  Files              276     276              
  Lines             8425    8425              
  Branches          1601    1601              
==============================================
- Hits              6303    6302       -1     
- Misses            1676    1677       +1     
  Partials           446     446
Impacted Files Coverage Δ
src/chronos/i18n/pl.ts 69.23% <0%> (-2.57%) ⬇️
src/chronos/i18n/cs.ts 84.74% <0%> (ø) ⬆️
src/chronos/i18n/sk.ts 80.85% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ee6eac...5e8db2c. Read the comment docs.

@ludmilanesvitiy
Copy link
Contributor

Datepicker DEMOs tested in Chrome, FF - looks good.

@Domainv Domainv added this to the 3.1.4 milestone Dec 14, 2018
@valorkin valorkin merged commit 46d1d23 into valor-software:development Dec 17, 2018
@ghost ghost removed the ready for merge label Dec 17, 2018
@daniloff200 daniloff200 deleted the remove-importants-in-datepicker-styles branch December 20, 2018 16:00
leo6104 pushed a commit to leo6104/ngx-bootstrap that referenced this pull request Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants