Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(demo): update landing page #4972

Merged
merged 2 commits into from Dec 21, 2018
Merged

feat(demo): update landing page #4972

merged 2 commits into from Dec 21, 2018

Conversation

ghost
Copy link

@ghost ghost commented Dec 21, 2018

Closes to #4970

@ghost ghost added the needs review label Dec 21, 2018
@codecov
Copy link

codecov bot commented Dec 21, 2018

Codecov Report

Merging #4972 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #4972   +/-   ##
============================================
  Coverage        74.79%   74.79%           
============================================
  Files              277      277           
  Lines             8434     8434           
  Branches          1602     1602           
============================================
  Hits              6308     6308           
  Misses            1683     1683           
  Partials           443      443

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac7b7a3...6edc9c6. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 21, 2018

Codecov Report

Merging #4972 into development will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4972      +/-   ##
===============================================
- Coverage        74.79%   74.78%   -0.02%     
===============================================
  Files              277      277              
  Lines             8434     8434              
  Branches          1602     1602              
===============================================
- Hits              6308     6307       -1     
+ Misses            1683     1681       -2     
- Partials           443      446       +3
Impacted Files Coverage Δ
src/datepicker/engine/flag-days-calendar.ts 75% <0%> (-6.25%) ⬇️
src/chronos/utils/date-getters.ts 79.54% <0%> (-2.28%) ⬇️
src/datepicker/reducer/bs-datepicker.effects.ts 74.31% <0%> (+1.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac7b7a3...80789f8. Read the comment docs.

@valorkin valorkin merged commit a6f27ab into valor-software:development Dec 21, 2018
@ghost ghost removed the needs review label Dec 21, 2018
Copy link
Contributor

@ludmilanesvitiy ludmilanesvitiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to change link "There's no need to open an issue here if you want to ask general question, use StackOverflow or Slack instead" - in ISSUE_TEMPLATE.md

Also need to fix Cypress tests

Also need to fix links in CONTRIBUTING.md file

Crossbrowser testing sponsored by [Browser Stack](https://www.browserstack.com)
[<img src="https://camo.githubusercontent.com/a7b268f2785656ab3ca7b1cbb1633ee5affceb8f/68747470733a2f2f64677a6f7139623561736a67312e636c6f756466726f6e742e6e65742f70726f64756374696f6e2f696d616765732f6c61796f75742f6c6f676f2d6865616465722e706e67" alt="Browser Stack" height="31px" style="background: cornflowerblue;">](https://www.browserstack.com)
Crossbrowser testing sponsored by [Saucelab](https://saucelabs.com/)
[<img src="https://saucelabs.com/content/images/circle-logo@2x.png" alt="Browser Stack" width="31" height="31">](https://saucelabs.com/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by [Saucelabs]
alt="Saucelabs"

@@ -166,8 +167,10 @@ <h3>If you need more modules check <a href="https://github.com/valor-software/ng
<h3>Credits</h3>

<p>Crossbrowser testing sponsored by
<a href="https://www.browserstack.com">Browser Stack</a>
<a href="https://www.browserstack.com"><img src="https://camo.githubusercontent.com/a7b268f2785656ab3ca7b1cbb1633ee5affceb8f/68747470733a2f2f64677a6f7139623561736a67312e636c6f756466726f6e742e6e65742f70726f64756374696f6e2f696d616765732f6c61796f75742f6c6f676f2d6865616465722e706e67" alt="Browser Stack" height="31px"></a>
<a href="https://saucelabs.com/" class="pr-1">Saucelab</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saucelabs

<a href="https://www.browserstack.com"><img src="https://camo.githubusercontent.com/a7b268f2785656ab3ca7b1cbb1633ee5affceb8f/68747470733a2f2f64677a6f7139623561736a67312e636c6f756466726f6e742e6e65742f70726f64756374696f6e2f696d616765732f6c61796f75742f6c6f676f2d6865616465722e706e67" alt="Browser Stack" height="31px"></a>
<a href="https://saucelabs.com/" class="pr-1">Saucelab</a>
<a href="https://saucelabs.com/">
<img src="https://saucelabs.com/content/images/circle-logo@2x.png" alt="Browser Stack" width="31" height="31">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alt="Saucelabs"

leo6104 pushed a commit to leo6104/ngx-bootstrap that referenced this pull request Oct 10, 2019
* feat(demo): update landing page

* fix(landing): fix cypress tests after chahge langing
Closes valor-software#4970
IraErshova pushed a commit to IraErshova/ngx-bootstrap that referenced this pull request Jan 20, 2020
* feat(demo): update landing page

* fix(landing): fix cypress tests after chahge langing
Closes valor-software#4970
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants