Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tabs): fix an invoke of select event outside of tabs (#3755) #5002

Merged
merged 6 commits into from
Mar 19, 2019

Conversation

llysenko
Copy link
Contributor

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

Close #3755

@ghost ghost added the needs review label Jan 11, 2019
@codecov
Copy link

codecov bot commented Jan 11, 2019

Codecov Report

Merging #5002 into development will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5002   +/-   ##
============================================
  Coverage        74.79%   74.79%           
============================================
  Files              277      277           
  Lines             8436     8436           
  Branches          1603     1603           
============================================
  Hits              6310     6310           
  Misses            1680     1680           
  Partials           446      446
Impacted Files Coverage Δ
src/tabs/tab.directive.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac55b08...e13b052. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 11, 2019

Codecov Report

Merging #5002 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5002   +/-   ##
============================================
  Coverage        51.51%   51.51%           
============================================
  Files                3        3           
  Lines               99       99           
  Branches            17       17           
============================================
  Hits                51       51           
  Misses              38       38           
  Partials            10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 111ad96...28d0168. Read the comment docs.

@Domainv
Copy link
Contributor

Domainv commented Jan 11, 2019

You missed dynamic demo section

<tab *ngFor="let tabz of tabs"
         [heading]="tabz.title"
         [active]="tabz.active"
         (select)="tabz.active = true"
         (deselect)="tabz.active = false"
         [disabled]="tabz.disabled"
         [removable]="tabz.removable"
         (removed)="removeTabHandler(tabz)"
         [customClass]="tabz.customClass">
      {{tabz?.content}}
    </tab>

Domainv
Domainv previously approved these changes Jan 14, 2019
@ludmilanesvitiy
Copy link
Contributor

Tested in Chrome, FF - looks good. Checked tabs comp-t with input, selecting input text don't fire select event anymore. Looks good.

@Domainv Domainv added this to the 3.3.1 milestone Mar 18, 2019
@ghost ghost assigned Domainv Mar 18, 2019
@Domainv Domainv force-pushed the fix-tabs-select branch 4 times, most recently from 0744167 to 6451f37 Compare March 19, 2019 16:53
@Domainv Domainv force-pushed the fix-tabs-select branch 6 times, most recently from dd4d916 to 6d5972d Compare March 19, 2019 20:56
@Domainv Domainv merged commit de2300c into valor-software:development Mar 19, 2019
@ghost ghost removed the ready for merge label Mar 19, 2019
@ludmilanesvitiy ludmilanesvitiy mentioned this pull request Apr 25, 2019
5 tasks
leo6104 pushed a commit to leo6104/ngx-bootstrap that referenced this pull request Oct 10, 2019
…are#3755) (valor-software#5002)

* fix(tabs): fix an invoke of select event outside of tabs (valor-software#3755)
* fix(travis): fix travis on fork
IraErshova pushed a commit to IraErshova/ngx-bootstrap that referenced this pull request Jan 20, 2020
…are#3755) (valor-software#5002)

* fix(tabs): fix an invoke of select event outside of tabs (valor-software#3755)
* fix(travis): fix travis on fork
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants