-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tabs): fix an invoke of select event outside of tabs (#3755) #5002
Conversation
106edea
to
e13b052
Compare
Codecov Report
@@ Coverage Diff @@
## development #5002 +/- ##
============================================
Coverage 74.79% 74.79%
============================================
Files 277 277
Lines 8436 8436
Branches 1603 1603
============================================
Hits 6310 6310
Misses 1680 1680
Partials 446 446
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## development #5002 +/- ##
============================================
Coverage 51.51% 51.51%
============================================
Files 3 3
Lines 99 99
Branches 17 17
============================================
Hits 51 51
Misses 38 38
Partials 10 10 Continue to review full report at Codecov.
|
You missed dynamic demo section
|
e13b052
to
d50904d
Compare
Tested in Chrome, FF - looks good. Checked tabs comp-t with input, selecting input text don't fire select event anymore. Looks good. |
0744167
to
6451f37
Compare
dd4d916
to
6d5972d
Compare
6d5972d
to
28d0168
Compare
…are#3755) (valor-software#5002) * fix(tabs): fix an invoke of select event outside of tabs (valor-software#3755) * fix(travis): fix travis on fork
…are#3755) (valor-software#5002) * fix(tabs): fix an invoke of select event outside of tabs (valor-software#3755) * fix(travis): fix travis on fork
PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.
Close #3755