Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): rework tests according to new position service #5055

Merged
merged 1 commit into from
Feb 11, 2019

Conversation

ludmilanesvitiy
Copy link
Contributor

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@ludmilanesvitiy ludmilanesvitiy self-assigned this Feb 11, 2019
@ghost ghost added the needs review label Feb 11, 2019
@ludmilanesvitiy ludmilanesvitiy changed the title fix(tests): rework tests accotding to new position service fix(tests): rework tests according to new position service Feb 11, 2019
@codecov
Copy link

codecov bot commented Feb 11, 2019

Codecov Report

Merging #5055 into development will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5055      +/-   ##
===============================================
- Coverage        74.44%   74.43%   -0.02%     
===============================================
  Files              316      316              
  Lines             8870     8870              
  Branches          1734     1734              
===============================================
- Hits              6603     6602       -1     
+ Misses            1774     1770       -4     
- Partials           493      498       +5
Impacted Files Coverage Δ
src/chronos/i18n/it.ts 71.42% <0%> (-28.58%) ⬇️
...themes/bs/bs-datepicker-day-decorator.directive.ts 81.81% <0%> (-18.19%) ⬇️
src/datepicker/engine/flag-days-calendar.ts 75% <0%> (-6.25%) ⬇️
src/chronos/i18n/uk.ts 78.04% <0%> (-2.44%) ⬇️
src/chronos/i18n/cs.ts 86.44% <0%> (+1.69%) ⬆️
src/datepicker/reducer/bs-datepicker.effects.ts 74.1% <0%> (+1.78%) ⬆️
src/chronos/i18n/sk.ts 82.97% <0%> (+2.12%) ⬆️
src/chronos/i18n/pl.ts 74.35% <0%> (+5.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2aaa80...b9b14e4. Read the comment docs.

@valorkin valorkin merged commit 8a94917 into development Feb 11, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-e2e-popover branch February 11, 2019 14:55
@ghost ghost removed the needs review label Feb 11, 2019
leo6104 pushed a commit to leo6104/ngx-bootstrap that referenced this pull request Oct 10, 2019
IraErshova pushed a commit to IraErshova/ngx-bootstrap that referenced this pull request Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants