Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): fix sauce tests #5057

Merged
merged 2 commits into from
Feb 12, 2019
Merged

fix(tests): fix sauce tests #5057

merged 2 commits into from
Feb 12, 2019

Conversation

Domainv
Copy link
Contributor

@Domainv Domainv commented Feb 12, 2019

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@ghost ghost assigned Domainv Feb 12, 2019
@ghost ghost added the needs review label Feb 12, 2019
@Domainv Domainv force-pushed the fix-sauce-tests branch 2 times, most recently from 23b796a to b5232b4 Compare February 12, 2019 17:45
@codecov
Copy link

codecov bot commented Feb 12, 2019

Codecov Report

❗ No coverage uploaded for pull request base (development@b697cc5). Click here to learn what that means.
The diff coverage is 80%.

Impacted file tree graph

@@              Coverage Diff               @@
##             development    #5057   +/-   ##
==============================================
  Coverage               ?   74.43%           
==============================================
  Files                  ?      316           
  Lines                  ?     8869           
  Branches               ?     1734           
==============================================
  Hits                   ?     6602           
  Misses                 ?     1771           
  Partials               ?      496
Impacted Files Coverage Δ
src/positioning/modifiers/flip.ts 81.48% <ø> (ø)
src/positioning/utils/computeAutoPlacement.ts 83.33% <ø> (ø)
src/positioning/modifiers/initData.ts 85.71% <80%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b697cc5...d3c2ab9. Read the comment docs.

@valorkin valorkin merged commit 0bc4a69 into development Feb 12, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-sauce-tests branch February 12, 2019 20:20
@ghost ghost removed the needs review label Feb 12, 2019
leo6104 pushed a commit to leo6104/ngx-bootstrap that referenced this pull request Oct 10, 2019
IraErshova pushed a commit to IraErshova/ngx-bootstrap that referenced this pull request Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants