Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): fix cy all command #5108

Merged
merged 1 commit into from
Mar 18, 2019
Merged

fix(tests): fix cy all command #5108

merged 1 commit into from
Mar 18, 2019

Conversation

ludmilanesvitiy
Copy link
Contributor

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@ludmilanesvitiy ludmilanesvitiy self-assigned this Mar 18, 2019
@ludmilanesvitiy ludmilanesvitiy requested a review from Domainv March 18, 2019 09:11
@ghost ghost added the needs review label Mar 18, 2019
@ludmilanesvitiy ludmilanesvitiy added this to the 3.3.1 milestone Mar 18, 2019
@codecov
Copy link

codecov bot commented Mar 18, 2019

Codecov Report

Merging #5108 into development will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5108      +/-   ##
===============================================
+ Coverage         74.5%   74.52%   +0.02%     
===============================================
  Files              317      317              
  Lines             8902     8902              
  Branches          1740     1740              
===============================================
+ Hits              6632     6634       +2     
+ Misses            1774     1770       -4     
- Partials           496      498       +2
Impacted Files Coverage Δ
src/chronos/i18n/it.ts 71.42% <0%> (-28.58%) ⬇️
src/chronos/i18n/uk.ts 78.04% <0%> (-2.44%) ⬇️
src/datepicker/bs-datepicker.component.ts 63.41% <0%> (-1.22%) ⬇️
src/chronos/i18n/cs.ts 86.44% <0%> (+1.69%) ⬆️
src/datepicker/reducer/bs-datepicker.effects.ts 74.1% <0%> (+1.78%) ⬆️
src/chronos/i18n/sk.ts 82.97% <0%> (+2.12%) ⬆️
src/chronos/i18n/pl.ts 74.35% <0%> (+5.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8dd0a6...ac9fc83. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 18, 2019

Codecov Report

Merging #5108 into development will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5108      +/-   ##
===============================================
+ Coverage         74.5%   74.52%   +0.02%     
===============================================
  Files              317      317              
  Lines             8902     8902              
  Branches          1740     1740              
===============================================
+ Hits              6632     6634       +2     
+ Misses            1774     1770       -4     
- Partials           496      498       +2
Impacted Files Coverage Δ
src/chronos/i18n/it.ts 71.42% <0%> (-28.58%) ⬇️
src/chronos/i18n/uk.ts 78.04% <0%> (-2.44%) ⬇️
src/datepicker/bs-datepicker.component.ts 63.41% <0%> (-1.22%) ⬇️
src/chronos/i18n/cs.ts 86.44% <0%> (+1.69%) ⬆️
src/datepicker/reducer/bs-datepicker.effects.ts 74.1% <0%> (+1.78%) ⬆️
src/chronos/i18n/sk.ts 82.97% <0%> (+2.12%) ⬆️
src/chronos/i18n/pl.ts 74.35% <0%> (+5.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8dd0a6...ac9fc83. Read the comment docs.

@Domainv Domainv merged commit ea66fa4 into development Mar 18, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-tests-command branch March 18, 2019 09:35
@ghost ghost removed the needs review label Mar 18, 2019
leo6104 pushed a commit to leo6104/ngx-bootstrap that referenced this pull request Oct 10, 2019
IraErshova pushed a commit to IraErshova/ngx-bootstrap that referenced this pull request Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants