-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(positioning): fix frozen page #5119
Conversation
Codecov Report
@@ Coverage Diff @@
## development #5119 +/- ##
============================================
Coverage 51.51% 51.51%
============================================
Files 3 3
Lines 99 99
Branches 17 17
============================================
Hits 51 51
Misses 38 38
Partials 10 10 Continue to review full report at Codecov.
|
Smoke tested, in Chrome and FF - looks good. |
fyi - I'm still getting frozen pages with 4.1.1. Reverting to 3.2.0 resolves it. |
@hisham Hi! Could you, pls specify steps for reproducing frozen page? |
I don't have exact repro steps unfortunately. It just freezes my app as soon as I go over a tooltip. This issue happened since you refactored the positioning service but I didn't have exact repro steps so didn't log a bug. Was then happy you found it yourself and made a fix but looks like the issue is still there for certain cases atleast. |
We encountered this same issue. We could eventually reproduce it by having the plugin "LastPass" or "Grammarly" installed in Chrome. We went back to 3.2.0 and that seems to fix it for us. |
4.1.1 and on Chrome (Version 73.0.3683.103 (Official Build) (64-bit)) Grammarly installed. in Dev it works fine, prod (default config) and with aot it is freezing. |
* fix(positioning): fix frozen page * fix(common): change to actual peerDependencies
* fix(positioning): fix frozen page * fix(common): change to actual peerDependencies
PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.