Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(positioning): fix frozen page #5119

Merged
merged 2 commits into from
Mar 22, 2019
Merged

fix(positioning): fix frozen page #5119

merged 2 commits into from
Mar 22, 2019

Conversation

Domainv
Copy link
Contributor

@Domainv Domainv commented Mar 21, 2019

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@codecov
Copy link

codecov bot commented Mar 21, 2019

Codecov Report

Merging #5119 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5119   +/-   ##
============================================
  Coverage        51.51%   51.51%           
============================================
  Files                3        3           
  Lines               99       99           
  Branches            17       17           
============================================
  Hits                51       51           
  Misses              38       38           
  Partials            10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34f73e5...5fc0025. Read the comment docs.

@ludmilanesvitiy
Copy link
Contributor

Smoke tested, in Chrome and FF - looks good.

@Domainv Domainv merged commit 67bb329 into development Mar 22, 2019
@ghost ghost removed the ready for merge label Mar 22, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-frozen-page branch March 22, 2019 12:03
@hisham
Copy link

hisham commented Apr 11, 2019

fyi - I'm still getting frozen pages with 4.1.1. Reverting to 3.2.0 resolves it.

@ludmilanesvitiy
Copy link
Contributor

@hisham Hi! Could you, pls specify steps for reproducing frozen page?

@hisham
Copy link

hisham commented Apr 12, 2019

I don't have exact repro steps unfortunately. It just freezes my app as soon as I go over a tooltip. This issue happened since you refactored the positioning service but I didn't have exact repro steps so didn't log a bug. Was then happy you found it yourself and made a fix but looks like the issue is still there for certain cases atleast.

@JelleVisser
Copy link

We encountered this same issue. We could eventually reproduce it by having the plugin "LastPass" or "Grammarly" installed in Chrome. We went back to 3.2.0 and that seems to fix it for us.

@niteshpurohit
Copy link

4.1.1 and on Chrome (Version 73.0.3683.103 (Official Build) (64-bit)) Grammarly installed. in Dev it works fine, prod (default config) and with aot it is freezing.
Then uninstalled Grammarly from chrome, site starts working.

leo6104 pushed a commit to leo6104/ngx-bootstrap that referenced this pull request Oct 10, 2019
* fix(positioning): fix frozen page
* fix(common): change to actual peerDependencies
IraErshova pushed a commit to IraErshova/ngx-bootstrap that referenced this pull request Jan 20, 2020
* fix(positioning): fix frozen page
* fix(common): change to actual peerDependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants