Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(carousel): allow to display multiple items per one slide #5133

Merged
merged 1 commit into from
Apr 22, 2019
Merged

feat(carousel): allow to display multiple items per one slide #5133

merged 1 commit into from
Apr 22, 2019

Conversation

musienkoyuriy
Copy link
Contributor

@musienkoyuriy musienkoyuriy commented Mar 28, 2019 •
edited by Domainv
Loading

Closes #965

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@musienkoyuriy musienkoyuriy self-assigned this Mar 28, 2019
@musienkoyuriy musienkoyuriy requested a review from Domainv March 28, 2019 14:13
@ghost ghost added the needs review label Mar 28, 2019
@codecov
Copy link

codecov bot commented Mar 28, 2019 •
edited
Loading

Codecov Report

Merging #5133 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5133   +/-   ##
============================================
  Coverage        51.51%   51.51%           
============================================
  Files                3        3           
  Lines               99       99           
  Branches            17       17           
============================================
  Hits                51       51           
  Misses              38       38           
  Partials            10       10
Impacted Files Coverage Δ
demo/src/polyfills.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4711a61...72de80c. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 28, 2019

Codecov Report

Merging #5133 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5133   +/-   ##
============================================
  Coverage        51.51%   51.51%           
============================================
  Files                3        3           
  Lines               99       99           
  Branches            17       17           
============================================
  Hits                51       51           
  Misses              38       38           
  Partials            10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a3afe3...a596cf1. Read the comment docs.

@musienkoyuriy musienkoyuriy force-pushed the feat-multilist-carousel branch 13 times, most recently from 66de1f8 to 8b2b997 Compare April 3, 2019 12:10
@musienkoyuriy musienkoyuriy force-pushed the feat-multilist-carousel branch 12 times, most recently from f2cdab2 to e22cc8f Compare April 9, 2019 14:55
@musienkoyuriy musienkoyuriy force-pushed the feat-multilist-carousel branch from a58ce1f to 267d406 Compare April 16, 2019 09:56
@musienkoyuriy musienkoyuriy changed the title WIP. feat(carousel): allow to display multiple items per one slide feat(carousel): allow to display multiple items per one slide Apr 16, 2019
@musienkoyuriy musienkoyuriy force-pushed the feat-multilist-carousel branch 2 times, most recently from 72de80c to dd1fe87 Compare April 16, 2019 15:35
@codecov-io
Copy link

Codecov Report

Merging #5133 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5133   +/-   ##
============================================
  Coverage        51.51%   51.51%           
============================================
  Files                3        3           
  Lines               99       99           
  Branches            17       17           
============================================
  Hits                51       51           
  Misses              38       38           
  Partials            10       10
Impacted Files Coverage Δ
demo/src/polyfills.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4711a61...dd1fe87. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Apr 16, 2019 •
edited by codecov bot
Loading

Codecov Report

Merging #5133 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5133   +/-   ##
============================================
  Coverage        51.51%   51.51%           
============================================
  Files                3        3           
  Lines               99       99           
  Branches            17       17           
============================================
  Hits                51       51           
  Misses              38       38           
  Partials            10       10
Impacted Files Coverage Δ
demo/src/polyfills.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecdc140...178806c. Read the comment docs.

@musienkoyuriy musienkoyuriy force-pushed the feat-multilist-carousel branch from dd1fe87 to 6327000 Compare April 17, 2019 13:34
Domainv
Domainv previously approved these changes Apr 17, 2019
View reviewed changes
@ghost ghost assigned Domainv Apr 17, 2019
@musienkoyuriy musienkoyuriy force-pushed the feat-multilist-carousel branch 3 times, most recently from 44acc0d to c158359 Compare April 19, 2019 10:19
@Domainv Domainv added this to the 4.2.1 milestone Apr 19, 2019
@musienkoyuriy musienkoyuriy force-pushed the feat-multilist-carousel branch from c158359 to 178806c Compare April 22, 2019 09:52
@ghost ghost added the needs review label Apr 22, 2019
@ludmilanesvitiy
Copy link
Contributor

Smoke retested in Chrome, Edge - looks good.

@Domainv Domainv merged commit c9f4ec9 into valor-software:development Apr 22, 2019
leo6104 pushed a commit to leo6104/ngx-bootstrap that referenced this pull request Oct 10, 2019
@musienkoyuriy @leo6104
feat(carousel): allow to display multiple items per one slide (valor-…
f849826 
…software#5133)
IraErshova pushed a commit to IraErshova/ngx-bootstrap that referenced this pull request Jan 20, 2020
@musienkoyuriy @IraErshova
feat(carousel): allow to display multiple items per one slide (valor-…
703ed82 
…software#5133)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludmilanesvitiy ludmilanesvitiy ludmilanesvitiy left review comments

@Domainv Domainv Domainv approved these changes

Assignees

@musienkoyuriy musienkoyuriy

@Domainv Domainv

Labels
comp(carousel)
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.

feat(carousel): add support of multiple items in slide
4 participants
@musienkoyuriy @ludmilanesvitiy @codecov-io @Domainv