Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(date-range-picker): Include docs for DateRangepicker custom format #5199

Merged
merged 2 commits into from
Jun 21, 2019
Merged

docs(date-range-picker): Include docs for DateRangepicker custom format #5199

merged 2 commits into from
Jun 21, 2019

Conversation

AhsanAyaz
Copy link
Contributor

Added the demo of custom format for date range picker
I've tried to find this many times, and probably others do to :)

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • [] built and tested the changes locally.
  • [] added/updated tests.
  • [] added/updated API documentation.
  • [] added/updated demos.

@ghost ghost added the needs review label May 10, 2019
@ghost ghost assigned Domainv May 13, 2019
@Domainv Domainv added this to the 5.1.0 milestone Jun 7, 2019
@codecov
Copy link

codecov bot commented Jun 14, 2019

Codecov Report

Merging #5199 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5199   +/-   ##
============================================
  Coverage        51.51%   51.51%           
============================================
  Files                3        3           
  Lines               99       99           
  Branches            17       17           
============================================
  Hits                51       51           
  Misses              38       38           
  Partials            10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7f9e8c...8210deb. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 14, 2019

Codecov Report

Merging #5199 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5199   +/-   ##
============================================
  Coverage        51.04%   51.04%           
============================================
  Files                3        3           
  Lines               96       96           
  Branches            17       17           
============================================
  Hits                49       49           
  Misses              37       37           
  Partials            10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42cc778...56a9ada. Read the comment docs.

Domainv
Domainv previously approved these changes Jun 19, 2019
Domainv
Domainv previously approved these changes Jun 20, 2019
@ludmilanesvitiy
Copy link
Contributor

ludmilanesvitiy commented Jun 20, 2019

Need to update custom_date_format_spec.ts with

datepicker.isInputHaveAttrs(customFormat, [{ attr: 'formcontrolname', value: 'dateYMD' }], 0);
    datepicker.isInputHaveAttrs(customFormat, [{ attr: 'formcontrolname', value: 'dateMDY' }], 1);
    datepicker.isInputHaveAttrs(customFormat, [{ attr: 'formcontrolname', value: 'dateFull' }], 2);

@Domainv
Copy link
Contributor

Domainv commented Jun 21, 2019

fixed

@ludmilanesvitiy
Copy link
Contributor

Reviewed, looks good.

@Domainv Domainv merged commit b845340 into valor-software:development Jun 21, 2019
leo6104 pushed a commit to leo6104/ngx-bootstrap that referenced this pull request Oct 10, 2019
IraErshova pushed a commit to IraErshova/ngx-bootstrap that referenced this pull request Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants