Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: carousel - solved multi list slides no auto play #5237

Merged
merged 2 commits into from
Jun 6, 2019
Merged

fix: carousel - solved multi list slides no auto play #5237

merged 2 commits into from
Jun 6, 2019

Conversation

gioboa
Copy link
Contributor

@gioboa gioboa commented May 24, 2019

Solved this issue:
Even if I define interval in multi list carousel the component never start auto play.

Fixed #5236

@codecov
Copy link

codecov bot commented May 27, 2019

Codecov Report

Merging #5237 into development will increase coverage by 0.47%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5237      +/-   ##
===============================================
+ Coverage        51.04%   51.51%   +0.47%     
===============================================
  Files                3        3              
  Lines               96       99       +3     
  Branches            17       17              
===============================================
+ Hits                49       51       +2     
- Misses              37       38       +1     
  Partials            10       10
Impacted Files Coverage Δ
demo/src/app/app.component.ts 40.81% <0%> (+1.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e9489f...a36e0ef. Read the comment docs.

@ludmilanesvitiy
Copy link
Contributor

Tested, looks good.

@Domainv Domainv merged commit d4fd9ad into valor-software:development Jun 6, 2019
@gioboa gioboa deleted the fix/multilist-no-auto-play-#5236 branch June 7, 2019 14:36
leo6104 pushed a commit to leo6104/ngx-bootstrap that referenced this pull request Oct 10, 2019
IraErshova pushed a commit to IraErshova/ngx-bootstrap that referenced this pull request Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

carousel: multilist slides never start auto play
3 participants