Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip tooltipChange subscription not cleaned up #5415

Closed
aeleneski opened this issue Oct 2, 2019 · 3 comments
Closed

Tooltip tooltipChange subscription not cleaned up #5415

aeleneski opened this issue Oct 2, 2019 · 3 comments
Assignees
Milestone

Comments

@aeleneski
Copy link

Bug description or feature request:

In TooltipDirective there is a subscription to this.tooltipChange.subscribe that is not being unsubscribed in the ngOnDestroy method.

Plunker/StackBlitz that reproduces the issue:

Using Plunkr, StackBlitz is the best way to show your issue. Issues without link to an example of reproduction might be closed.

You can use one of starter templates:

Plunkr: https://plnkr.co/edit/0NipkZrnckZZROAcnjzB?p=preview

StackBlitz: https://stackblitz.com/edit/ngx-bootstrap?file=app%2Fapp.module.ts

Versions of ngx-bootstrap, Angular, and Bootstrap:

ngx-bootstrap: 3.2.0

Angular: 7.2.7

Bootstrap: 4.3.1

Build system: Angular CLI, System.js, webpack, starter seed: Angular CLI

@haridevelops
Copy link
Contributor

#5431 closes this issue.

@haridevelops
Copy link
Contributor

great if you add hacktoberfest label

@haridevelops
Copy link
Contributor

Waiting for review approval

@Domainv Domainv modified the milestones: 5.3.1, 5.4.0 Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants