feat(tabs): add aria attributes #5605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add role attribute Add aria-selected attribute Add aria-controls attribute Add aria-labelledby attribute Add aria-label attribute to TabsetConfig Close valor-software#4120
daniloff200
approved these changes
Jan 21, 2020
Codecov Report
@@ Coverage Diff @@
## development #5605 +/- ##
============================================
Coverage 52.52% 52.52%
============================================
Files 3 3
Lines 99 99
Branches 17 17
============================================
Hits 52 52
Misses 37 37
Partials 10 10Continue to review full report at Codecov.
|
dmitry-zhemchugov
approved these changes
Jan 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add role attribute
Add aria-selected attribute
Add aria-controls attribute
Add aria-labelledby attribute
Add aria-label attribute to TabsetConfig
Close #4120
PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.