feat(daterangepicker): add ability to select week as a daterange #5611

daniloff200 · 2020-01-22T16:45:34Z

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

read and followed the CONTRIBUTING.md guide.
built and tested the changes locally.
added/updated tests.
added/updated API documentation.
added/updated demos.

codecov · 2020-01-22T17:18:10Z

Codecov Report

Merging #5611 into development will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           development    #5611   +/-   ##
============================================
  Coverage        52.52%   52.52%           
============================================
  Files                3        3           
  Lines               99       99           
  Branches            17       17           
============================================
  Hits                52       52           
  Misses              37       37           
  Partials            10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e594b1...9b8d8a8. Read the comment docs.

IraErshova · 2020-01-28T09:28:09Z

demo/src/ng-api-doc.ts

@@ -1044,7 +1044,12 @@ export const ngdoc: any = {
      {
        "name": "selectWeek",
        "type": "boolean",
-        "description": "<p>Makes dates from other months active</p>\n"
+        "description": "<p>Makes weeks selectable, and mark first available date of the week as selected</p>\n"


Did you generate this code or add it manually?

yeah, previously that was added manually, now I used demo.gen-docs script

IraErshova · 2020-01-28T09:30:06Z

src/datepicker/themes/bs/bs-days-calendar-view.component.ts

-    if (week.days.length === 0) {
-      return;
+    if (this._config.selectWeek) {
+      if (week.days


Could you please merge these conditions?

… into week-daterange-select-5588

valorkin

looks good to me

dmitry-zhemchugov · 2020-02-03T15:09:36Z

Tested ready to merge

dmitry-zhemchugov

Ready to merge

Vinoth-deva · 2020-08-11T15:52:46Z

How to Implement this? ability to select Week

daniloff200 · 2020-08-11T17:39:48Z

@Vinoth-deva I don't understand your question.
Do you want to ask, how to use this functionality in your project, or what?

Vinoth-deva · 2020-08-12T08:11:22Z

@Vinoth-deva I don't understand your question.
Do you want to ask, how to use this functionality in your project, or what?

Yes, Thank you so much for the reply, @daniloff200 i want to know how to use this functionality in my project

daniloff200 · 2020-08-12T08:15:29Z

@Vinoth-deva check this out https://valor-software.com/ngx-bootstrap/#/datepicker#select-week-range

Vinoth-deva · 2020-08-12T08:22:43Z

i had a look into it, there if we select the week number its selecting first day of the week, but in my case if user select any of the day i want to select the entire week @daniloff200 as shown in the XD

daniloff200 · 2020-08-12T08:54:59Z

Well, we don't have such functionality, but, you can try to use a workaround.
We have ability to use daterangepicker with a one month only showing, check https://valor-software.com/ngx-bootstrap/#/datepicker#display-one-month
Also, when user selects a date, you have to programatically find out, for what daterange this date belongs to, for example, if it 14th July, that should be 07/12/2020 - 07/18/2020, and, range will be selected

daniloff200 added comp(datepicker) WIP labels Jan 22, 2020

daniloff200 force-pushed the week-daterange-select-5588 branch 2 times, most recently from 5eec928 to a611cc7 Compare January 23, 2020 09:59

daniloff200 requested a review from valorkin January 23, 2020 10:03

daniloff200 added ready for review and removed WIP labels Jan 23, 2020

daniloff200 requested review from IraErshova and dmitry-zhemchugov January 23, 2020 10:03

daniloff200 changed the title ~~feat(daterangepicker): add ability to select week as a daterange [WIP]~~ feat(daterangepicker): add ability to select week as a daterange Jan 23, 2020

daniloff200 force-pushed the week-daterange-select-5588 branch 2 times, most recently from ebc2d0b to 5533c2d Compare January 23, 2020 10:49

feat(daterangepicker): add ability to select week as a daterange

d212b67

daniloff200 force-pushed the week-daterange-select-5588 branch from 5533c2d to d212b67 Compare January 23, 2020 11:38

IraErshova reviewed Jan 28, 2020

View reviewed changes

Merge branch 'development' of github.com:valor-software/ngx-bootstrap…

6dc1d33

… into week-daterange-select-5588

daniloff200 force-pushed the week-daterange-select-5588 branch from e4d70fd to 6dc1d33 Compare January 28, 2020 09:47

IraErshova approved these changes Jan 28, 2020

View reviewed changes

valorkin approved these changes Jan 31, 2020

View reviewed changes

Merge branch 'development' into week-daterange-select-5588

6e594b1

valorkin assigned dmitry-zhemchugov Jan 31, 2020

valorkin added ready for tests and removed ready for review labels Jan 31, 2020

Merge branch 'development' into week-daterange-select-5588

9b8d8a8

dmitry-zhemchugov added issue needs fix and removed ready for tests issue labels Feb 3, 2020

dmitry-zhemchugov added ready for merge and removed needs fix labels Feb 3, 2020

dmitry-zhemchugov assigned daniloff200 and unassigned dmitry-zhemchugov Feb 3, 2020

dmitry-zhemchugov approved these changes Feb 3, 2020

View reviewed changes

daniloff200 merged commit e65bf65 into development Feb 3, 2020

delete-merged-branch bot deleted the week-daterange-select-5588 branch February 3, 2020 15:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(daterangepicker): add ability to select week as a daterange #5611

feat(daterangepicker): add ability to select week as a daterange #5611

daniloff200 commented Jan 22, 2020 •

edited

Loading

codecov bot commented Jan 22, 2020 •

edited

Loading

IraErshova Jan 28, 2020

daniloff200 Jan 28, 2020

IraErshova Jan 28, 2020

daniloff200 Jan 28, 2020

valorkin left a comment

dmitry-zhemchugov commented Feb 3, 2020

dmitry-zhemchugov left a comment

Vinoth-deva commented Aug 11, 2020

daniloff200 commented Aug 11, 2020

Vinoth-deva commented Aug 12, 2020

daniloff200 commented Aug 12, 2020

Vinoth-deva commented Aug 12, 2020 •

edited

Loading

daniloff200 commented Aug 12, 2020

feat(daterangepicker): add ability to select week as a daterange #5611

feat(daterangepicker): add ability to select week as a daterange #5611

Conversation

daniloff200 commented Jan 22, 2020 • edited Loading

PR Checklist

codecov bot commented Jan 22, 2020 • edited Loading

Codecov Report

IraErshova Jan 28, 2020

Choose a reason for hiding this comment

daniloff200 Jan 28, 2020

Choose a reason for hiding this comment

IraErshova Jan 28, 2020

Choose a reason for hiding this comment

daniloff200 Jan 28, 2020

Choose a reason for hiding this comment

valorkin left a comment

Choose a reason for hiding this comment

dmitry-zhemchugov commented Feb 3, 2020

dmitry-zhemchugov left a comment

Choose a reason for hiding this comment

Vinoth-deva commented Aug 11, 2020

daniloff200 commented Aug 11, 2020

Vinoth-deva commented Aug 12, 2020

daniloff200 commented Aug 12, 2020

Vinoth-deva commented Aug 12, 2020 • edited Loading

daniloff200 commented Aug 12, 2020

daniloff200 commented Jan 22, 2020 •

edited

Loading

codecov bot commented Jan 22, 2020 •

edited

Loading

Vinoth-deva commented Aug 12, 2020 •

edited

Loading