feat(datepicker): add ability to show one month for daterangepicker depend on max/min date value #5667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…depends on max/min date value
IraErshova
reviewed
Feb 18, 2020
daniloff200
force-pushed
the
show-one-month-in-daterangepicker
branch
from
756ec0f to
cc13370
Compare
IraErshova
previously approved these changes
Feb 21, 2020
IraErshova
previously approved these changes
Feb 21, 2020
… into show-one-month-in-daterangepicker
daniloff200
force-pushed
the
show-one-month-in-daterangepicker
branch
from
d4b4c7d to
a178962
Compare
Codecov Report
@@ Coverage Diff @@
## development #5667 +/- ##
===============================================
+ Coverage 73.5% 73.63% +0.12%
===============================================
Files 322 323 +1
Lines 11595 11647 +52
Branches 2472 2481 +9
===============================================
+ Hits 8523 8576 +53
+ Misses 1983 1966 -17
- Partials 1089 1105 +16
Continue to review full report at Codecov.
|
valorkin
previously approved these changes
Feb 27, 2020
There was a problem hiding this comment.
LGTM overall
@daniloff200 please create an issue to move daterange specific staff to range picker and remove from date picker
IraErshova
previously approved these changes
Mar 2, 2020
IraErshova
approved these changes
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3595
PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.