-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(chore ci): change sourceRoot to deepen ng cli run scope, add ampe… #5674
fix(chore ci): change sourceRoot to deepen ng cli run scope, add ampe… #5674
Conversation
…rsands to prevent multiple scopes in script run.
Codecov Report
@@ Coverage Diff @@
## development #5674 +/- ##
===============================================
+ Coverage 73.52% 73.55% +0.03%
===============================================
Files 321 321
Lines 11538 11538
Branches 2457 2457
===============================================
+ Hits 8483 8487 +4
+ Misses 1968 1964 -4
Partials 1087 1087
Continue to review full report at Codecov.
|
@dmitry-zhemchugov for unknown reason, both Smoke tests jobs are failed |
@belinef thought that it could be because of his changes. Need more investigation |
…sts to prevent Errors while no tests in test-run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me, but I have doubts regarding this moment
http://dl3.joxi.net/drive/2020/02/20/0023/0818/1569586/86/a6974f8520.png
@belinef Could you please approve that this code is correct?
@IraErshova in case for |
fix(chore ci): change sourceRoot to deepen ng cli run scope, add ampersands to prevent multiple scopes in script run.