Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(accordion, collapse): fix according animation with collapse #5688

Merged
merged 2 commits into from
Feb 26, 2020

Conversation

daniloff200
Copy link
Contributor

resolves #5686

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@codecov
Copy link

codecov bot commented Feb 24, 2020

Codecov Report

Merging #5688 into development will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5688      +/-   ##
===============================================
- Coverage        73.72%   73.69%   -0.03%     
===============================================
  Files              323      323              
  Lines            11606    11614       +8     
  Branches          2471     2473       +2     
===============================================
+ Hits              8556     8559       +3     
- Misses            1957     1960       +3     
- Partials          1093     1095       +2     
Impacted Files Coverage Δ
src/collapse/collapse.directive.ts 72.56% <0.00%> (-3.63%) ⬇️
src/chronos/units/week-year.ts 91.54% <0.00%> (-1.41%) ⬇️
src/datepicker/utils/bs-calendar-utils.ts 84.84% <0.00%> (+6.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccb64f0...9007c05. Read the comment docs.

@dmitry-zhemchugov
Copy link
Contributor

Ready to merge

@daniloff200 daniloff200 merged commit 23800f5 into development Feb 26, 2020
@delete-merged-branch delete-merged-branch bot deleted the accordion-is-open-5686 branch February 26, 2020 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accordion [isOpen] isn't correctly responsive.
3 participants