Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datepicker): Add optional "today" button #5786

Merged
merged 22 commits into from
Jun 19, 2020

Conversation

pjlinn
Copy link
Contributor

@pjlinn pjlinn commented May 17, 2020

Add button for user to easily set today's date. Samples heavily from, and finishes closed PR: #5024

Potentially resolves #5680

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@daniloff200 daniloff200 self-requested a review May 18, 2020 12:55
@daniloff200 daniloff200 mentioned this pull request Jun 15, 2020
@daniloff200
Copy link
Contributor

I'm not sure, maybe I did something wrong, but, I wasn't able to see the button.
The same case, as it was for #5024, but, there was no demo at all. Here we have it, but, it looks like it doesn't work correctly

Does it work for you @pjlinn ?

Selection_023

@pjlinn
Copy link
Contributor Author

pjlinn commented Jun 15, 2020

Hey @daniloff200 , thanks for reviewing. I pulled in latest development and re-ran locally and it seems to be working. Screen shot taken after running the steps:

npm run build.watch // in first terminal
ng serve // in second

Is there a better command to verify it is working locally?

Screen Shot 2020-06-15 at 9 22 29 AM

@daniloff200
Copy link
Contributor

daniloff200 commented Jun 15, 2020

That's strange, I just completely rebuild all the app, and now it works
haha
🤣 😄
Well, looks good in general, I have an idea to make a positioning for this button, like, center,left,right

Gonna add some param for that later, and merge that

Thanks for your help, @pjlinn !!!

daniloff200
daniloff200 previously approved these changes Jun 15, 2020
@pjlinn
Copy link
Contributor Author

pjlinn commented Jun 15, 2020

No worries! Thank you again for the review (and ngx-bootstrap in general) 👍

Good idea about position.

@daniloff200 daniloff200 merged commit 41e7a0b into valor-software:development Jun 19, 2020
@pjlinn pjlinn deleted the datepicker-today-button branch June 19, 2020 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Today Date Button
2 participants