Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(modal): change to add Dismiss Reason on modal hide with back click #5942

Merged
merged 3 commits into from
Oct 1, 2020
Merged

fix(modal): change to add Dismiss Reason on modal hide with back click #5942

merged 3 commits into from
Oct 1, 2020

Conversation

cankitm
Copy link
Contributor

@cankitm cankitm commented Sep 30, 2020 •
edited
Loading

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

Ankit Mishra added 2 commits October 1, 2020 03:48
daniloff200
daniloff200 previously approved these changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@daniloff200 daniloff200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that!!!
Looks good for me!

@daniloff200 daniloff200 merged commit bf25a11 into valor-software:development Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniloff200 daniloff200 daniloff200 approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cankitm @daniloff200