Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should add 'Vary: Accept-Encoding' header when compress is used #1583

Closed
AutumnSun1996 opened this issue Jun 25, 2023 · 2 comments · Fixed by #1585
Closed

Should add 'Vary: Accept-Encoding' header when compress is used #1583

AutumnSun1996 opened this issue Jun 25, 2023 · 2 comments · Fixed by #1585

Comments

@AutumnSun1996
Copy link
Contributor

When responses are compressed, and may be compressed by different methods, responses should has 'Vary: Accept-Encoding' header so clients can get decodable content.
I think it should be such a build-in feature in the function CompressHandlerBrotliLevel, maybe with a config to turn it off.
@erikdubbelboer
Copy link
Collaborator

I agree, I'm not sure why this isn't being done yet. Can you make a pull request?

@AutumnSun1996
Copy link
Contributor Author

I'm glad to do that, will create one soon.

@AutumnSun1996 AutumnSun1996 mentioned this issue Jun 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Auto add 'Vary' header after compression AutumnSun1996/fasthttp
2 participants
@erikdubbelboer @AutumnSun1996