Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NewFastHTTPHandler does not set response status code. #1753

Closed
luisgarciaalanis opened this issue Apr 8, 2024 · 1 comment
Closed

NewFastHTTPHandler does not set response status code. #1753

luisgarciaalanis opened this issue Apr 8, 2024 · 1 comment

Comments

@luisgarciaalanis
Copy link

The NewFastHTTPHandler() handler does not set the Status code for the response:

https://github.com/valyala/fasthttp/blob/master/fasthttpadaptor/adaptor.go#L59

I have pointed the line of code that needs to be updated to set the status from the ctx response.
@erikdubbelboer
Copy link
Collaborator

It's a couple of lines below that?

fasthttp/fasthttpadaptor/adaptor.go

Line 65 in d3a9c74

ctx.SetStatusCode(w.StatusCode())

@luisgarciaalanis luisgarciaalanis mentioned this issue Apr 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@erikdubbelboer @luisgarciaalanis