Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove false positives #2

Open
2 tasks
evanplaice opened this issue Dec 27, 2019 · 3 comments
Open
2 tasks

Remove false positives #2

evanplaice opened this issue Dec 27, 2019 · 3 comments
Labels
fix up-for-grabs

Comments

@evanplaice
Copy link
Member

evanplaice commented Dec 27, 2019 •
edited
Loading

The parser needs to be updated and tests need to be added to ensure that no false positives are included in the output.

Changes

  • patch the parser
  • add tests/fixtures covering all the use cases

Note: The tests should be added to jqkill.spec.js, fixtures should be named with the pattern false[n].js

False positives include

  • variables starting in $ (ex observables)
  • template literals
  • minified output1

1 Minifiers do a lot of weird stuff that may look like jQuery. Exclusion via the ignore option may be the only fix
@itaditya
Copy link

Also template literals

${}

@evanplaice
Copy link
Member Author

evanplaice commented Dec 28, 2019 •
edited
Loading

Good catch

@evanplaice
Copy link
Member Author

evanplaice commented Dec 29, 2019 •
edited
Loading

@itaditya Do you want to work on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fix up-for-grabs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@evanplaice @itaditya