New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exit code is always success #1

Closed

evanplaice opened this issue Nov 28, 2019 · 1 comment

Labels

bug

Member

evanplaice commented Nov 28, 2019

When all tests pass, the parent process should exit 0 (ie success). When any test fails it should return 1 (ie fail).

Currently, the runner always returns 0

This won't affect users runnung the tests standalone.

This will mistakenly return a false positive when run as a part ofna script chain (ex CI/CD).

A more robust parallel child process runner is in the works.

evanplaice added the bug label

Member Author

evanplaice commented Nov 28, 2019

Fixed in v1.0.1

evanplaice closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment