Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pom packaging is not written #82

Closed
gabrielittner opened this issue Jan 19, 2020 · 9 comments
Closed

Pom packaging is not written #82

gabrielittner opened this issue Jan 19, 2020 · 9 comments

Comments

@gabrielittner
Copy link
Collaborator

It's only written for Android libraries in legacy mode. I guess that AGP adds it there. The one set through this plugin never makes it to the pom file.

Example https://repo.maven.apache.org/maven2/com/vanniktech/gradle-maven-publish-plugin/0.8.0/gradle-maven-publish-plugin-0.8.0.pom

@ZacSweers
Copy link
Collaborator

This prevents us from using the non-legacy mode in 0.9.0 as well on https://github.com/slackhq/keeper

@gabrielittner
Copy link
Collaborator Author

@ZacSweers For non Android projects it's also broken in non legacy mode. From a very cursory check it didn't even work with the Chris Bane's script 4 years ago. https://repo.maven.apache.org/maven2/com/slack/keeper/keeper/0.2.0/keeper-0.2.0.pom

@gabrielittner
Copy link
Collaborator Author

Did you see any issues from not having it?

@ZacSweers
Copy link
Collaborator

yeah our upload fails pom validation on sonatype when we tried the new API. Memory is fuzzy but it was complaining about missing POM_URL and a number of other elements

@ZacSweers
Copy link
Collaborator

CC @jschear in case he remembers any other tidbits

@gabrielittner
Copy link
Collaborator Author

Ok, will take a look. I've got a theory what it might be.

@ZacSweers
Copy link
Collaborator

We'll try to do another repro and get a screenshot of the sonatype-reported errors

@gabrielittner
Copy link
Collaborator Author

It's fine. I've just tried it out locally and can see what's going wrong. Looks like we need some special configuration for gradle plugins.

@gabrielittner
Copy link
Collaborator Author

Closing this as packaging should come from the publication/component. For example Kotlin MPP sets the packaging for Kotlin/Native artifacts to klib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants