forked from MPAS-Dev/MPAS-Model
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing compounding factors on u2/v2 boundary conditions in ADC #14
Comments
If we are following the Andre et al. (1978) paper that Luke linked to in the other thread we should use
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Happy to do this PR, but just want to make sure which one we want to remove...
config_adc_up2_vp2_factor
is only used on u2 and v2:MPAS-Model/src/core_ocean/shared/mpas_ocn_adcReconstruct.F
Lines 273 to 274 in 5dc8d6e
config_adc_bc_const
is used on u2, v2, tp2, and sp2:MPAS-Model/src/core_ocean/shared/mpas_ocn_adcReconstruct.F
Lines 330 to 331 in 5dc8d6e
Do we want separate factors for u2/v2 and tp2/sp2?
The text was updated successfully, but these errors were encountered: