Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seems test case may be using the wrong model? #643

Closed
rossbar opened this issue Jan 11, 2023 · 0 comments · Fixed by #644
Closed

Seems test case may be using the wrong model? #643

rossbar opened this issue Jan 11, 2023 · 0 comments · Fixed by #644
Labels
chore Maintenance question Further information is requested

Comments

@rossbar
Copy link
Contributor

rossbar commented Jan 11, 2023

This was caught by the linter - there is a test that defines a mapping that, from the surrounding context, really seems like it's supposed to be used but isn't:

nsc2 = {'0': 2, '1': 3}
model2 = PanopticNet(num_semantic_classes=nsc1, **shared_kwargs)

FWIW I ran the tests locally using num_semantic_classes=nsc2 and everything still passes. If there is something obvious here that jumps out to others, please LMK - otherwise I will propose to update this.

@rossbar rossbar added question Further information is requested chore Maintenance labels Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant