Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for numpy 1.24.0 #109

Closed
msschwartz21 opened this issue Dec 20, 2022 · 2 comments
Closed

Add support for numpy 1.24.0 #109

msschwartz21 opened this issue Dec 20, 2022 · 2 comments
Labels
chore Maintenance

Comments

@msschwartz21
Copy link
Member

The recent release of numpy 1.24.0 introduced numerous issues in our tests likely because we have been ignoring deprecation warnings.
@msschwartz21 msschwartz21 added bug Something isn't working chore Maintenance and removed bug Something isn't working labels Dec 20, 2022
@msschwartz21 msschwartz21 mentioned this issue Dec 20, 2022
Merged
@rossbar
Copy link
Contributor

rossbar commented Dec 20, 2022

Yes, this affects all the deepcell libraries. Fortunately the fix is straightforward, it's just a matter of getting rid of the deprecated (now removed) numpy scalar aliases see e.g. vanvalenlab/deepcell-toolbox@c8ea830.

The short-term solution would be to pin numpy<1.24.

@rossbar
Copy link
Contributor

rossbar commented Jan 12, 2023

This has been fixed by #112

@rossbar rossbar closed this as completed Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rossbar @msschwartz21