Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLEASE Replace / in object by %2F #46

Closed
nathanfallet opened this issue May 30, 2022 · 0 comments · Fixed by #47
Closed

PLEASE Replace / in object by %2F #46

nathanfallet opened this issue May 30, 2022 · 0 comments · Fixed by #47
Labels
bug Something isn't working

Comments

@nathanfallet
Copy link
Member

I lost two hours trying to download an object from a bucket because I had a / in the object name (because it is in a subfolder) and it is not automatically escaped.
PLEASE ESCAPE IT HERE like shown on this answer on StackOverflow: https://stackoverflow.com/a/60585415/8261566
Also note that when using storage from Firebase in an iOS app, there is no need to escape it ourself, so it should be done automatically!

return request.send(method: .GET, headers: headers, path: "\(endpoint)/\(bucket)/o/\(object)", query: queryParams)

And everytime object appears in a URL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging a pull request may close this issue.

1 participant