Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow MySQLConnection creation without specifying an event loop #99

Open
2 tasks
gwynne opened this issue Aug 8, 2023 · 0 comments
Open
2 tasks

Allow MySQLConnection creation without specifying an event loop #99

gwynne opened this issue Aug 8, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@gwynne
Copy link
Member

gwynne commented Aug 8, 2023

[The equivalent of] cherry-picked from vapor/postgres-nio#388:

SwiftNIO has landed EventLoopGroup singletons in 2.58.0. See apple/swift-nio#2471.

We should add an additional MySQLConnection connect method, that internally uses the existing one, but uses the NIO singleton:

extension MySQLConnection {
    static func connect(
        to socketAddress: SocketAddress,
        username: String,
        database: String,
        password: String? = nil,
        tlsConfiguration: TLSConfiguration? = .makeClientConfiguration(),
        serverHostname: String? = nil,
        logger: Logger = .init(label: "codes.vapor.mysql")
    ) -> EventLoopFuture<MySQLConnection> {
        Self.connect(
            to: socketAddress,
            username: username,
            password: password,
            tlsConfiguration: tlsConfiguration,
            serverHostname: serverHostname,
            on: MultiThreadedEventLoopGroup.singleton.any()
        )
    }
}
  • Add API
  • Remove all EventLoopGroup usages in the README
@gwynne gwynne added enhancement New feature or request good first issue Good for newcomers labels Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant