feat(transaction): Adding withTransaction #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianfett
reviewed
Oct 11, 2024
adam-fowler
reviewed
Oct 11, 2024
fabianfett
reviewed
Dec 8, 2024
Comment on lines
102
to
109
| let _ = try await client.withTransaction(logger: logger) { transaction in | ||
| try await transaction.query( | ||
| """ | ||
| INSERT INTO "\(unescaped: tableName)" (uuid) VALUES (\(iterations)); | ||
| """, | ||
| logger: logger | ||
| ) | ||
| } |
There was a problem hiding this comment.
You don't check the error here at all. There is also nothing here to rollback.
There was a problem hiding this comment.
Tests have been updated. I apologize about skipping this part.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #519 +/- ##
==========================================
- Coverage 61.75% 61.68% -0.07%
==========================================
Files 125 125
Lines 10089 10099 +10
==========================================
Hits 6230 6230
- Misses 3859 3869 +10
|
fabianfett
reviewed
Feb 3, 2025
| /// - Parameter closure: A closure that uses the passed `PostgresConnection`. The closure **must not** capture | ||
| /// the provided `PostgresConnection`. | ||
| /// - Returns: The closure's return value. | ||
| public func withTransaction<Result>(_ process: (PostgresConnection) async throws -> Result) async throws -> Result { |
There was a problem hiding this comment.
I wonder if we should capture calling file and line here. Then we could attach that info to the error that is thrown. We would wrap the thrown error in a PostgresTransactionError. We could also attach the Rollback error, if that happens. cc @gwynne WDYT?
Co-authored-by: Fabian Fett <fabianfett@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass at feature #512
What's the best way to go about writing unit test for the withTransaction func?