Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't require queried for HGNC IDs to be present (#418) #422

Merged

Conversation

holtgrewe
Copy link
Contributor

No description provided.

@holtgrewe holtgrewe linked an issue Mar 1, 2024 that may be closed by this pull request
@holtgrewe holtgrewe enabled auto-merge (squash) March 1, 2024 12:47
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 73.93%. Comparing base (a0ec18e) to head (18894ba).

❗ Current head 18894ba differs from pull request most recent head 975a530. Consider uploading reports for the commit 975a530 to get more accurate results

Files Patch % Lines
src/server/actix_server/genes_clinvar.rs 0.00% 6 Missing ⚠️
src/server/actix_server/genes_info.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #422   +/-   ##
=======================================
  Coverage   73.93%   73.93%           
=======================================
  Files          79       79           
  Lines        8309     8307    -2     
=======================================
- Hits         6143     6142    -1     
+ Misses       2166     2165    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@holtgrewe holtgrewe disabled auto-merge March 1, 2024 12:55
@holtgrewe holtgrewe merged commit 6fc4063 into main Mar 1, 2024
6 checks passed
@holtgrewe holtgrewe deleted the 418-return-404-rather-than-500-if-gene-could-not-be-found branch March 1, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return 404 rather than 500 if gene could not be found
1 participant