Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should TInput have type="text" attribute set by default? #50

Open
invokermain opened this issue Jan 11, 2022 · 0 comments
Open

Should TInput have type="text" attribute set by default? #50

invokermain opened this issue Jan 11, 2022 · 0 comments

Comments

@invokermain
Copy link

invokermain commented Jan 11, 2022

Tailwind forms plug in says: Note that for text inputs, you must add the type="text" attribute for these styles to take effect.

As this library relies on that plugin, the user has to know to set type="text" on all default t-input components to have the correct theming. Which will probably catch people out like it just did to me. This issue seems to affect the development (i.e. example) repo as well.

Is it worth setting this as a default attribute to ensure consistent theming? As currently you will not be aware of this fact unless you read the forms plugin documentation.

P.S. this library is super cool, keep it up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant