Skip to content
This repository has been archived by the owner on May 8, 2023. It is now read-only.

[Bug] Catch reporting exceptions to avoid UI errors #5

Closed
foxted opened this issue Dec 1, 2019 · 0 comments · Fixed by #6
Closed

[Bug] Catch reporting exceptions to avoid UI errors #5

foxted opened this issue Dec 1, 2019 · 0 comments · Fixed by #6
Labels
bug Something isn't working core Related to the core functionality of the engine

Comments

@foxted
Copy link
Member

foxted commented Dec 1, 2019 •
edited
Loading

From VariateHQ/variate-vue#2

Is your feature request related to a problem? Please describe.

As a marketer, I want to avoid the UI of my application to break due to an exception that occurs during reporting.

Describe the solution you'd like

Catch (and describe) any reporting exceptions without letting them affect how a page is rendered to the user.

Describe alternatives you've considered

Only allow the exception to occur when debug: true.

Additional context
@foxted foxted added bug Something isn't working core Related to the core functionality of the engine labels Dec 1, 2019
foxted added a commit that referenced this issue Dec 2, 2019
@foxted
fix(#5): call reporter in try/catch block
35b64e9
@foxted foxted mentioned this issue Dec 2, 2019
Merged
3 tasks
@foxted foxted closed this as completed in #6 Dec 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working core Related to the core functionality of the engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Typescript, Better Unit tests, reporter silent fail VariateHQ/variate-engine
1 participant
@foxted