Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make client sampler class #54

Open
fvarno opened this issue Aug 13, 2022 · 1 comment
Open

make client sampler class #54

fvarno opened this issue Aug 13, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@fvarno
Copy link
Contributor

fvarno commented Aug 13, 2022

There are different ways of sampling clients. Currently we pass the sampling scheme and rate directly as algorithm arguments. It is better to make client sampler a seperate class and an instance is made and passed to the algorithm as argument instead.

@fvarno fvarno added the enhancement New feature or request label Aug 13, 2022
@fvarno fvarno self-assigned this Aug 13, 2022
@fvarno
Copy link
Contributor Author

fvarno commented Aug 14, 2022

An alternate solution is to create a ClientManager class and move the _client memory definition there. It would be more interesting if DataManager also supported assigning clients to partition indices (Mapping). The assignment could be defined by a ClientManager class's public API method. Thus, if the number of clients is less than the number of partitions, the selected partitions can be drawn in any predetermined order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant