-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider not depending on PHP Sockets extension #117
Comments
It looks like some of these lines (the This issue is not as relevant for me now, but I'm not sure if it still might be considered. If it will not, feel free to close the issue. |
The issue may actually still be relevant now, because from time to time a connexion causes an error and the websocket server crashes because of |
Hi,
I'm currently using Wrench 2 and wanted to upgrade to Wrench 3, only to realize that my webhost PHP install doesn't have the PHP Sockets extension enabled.
It looks like even though
ext-sockets
is and was listed as a platform requirement, it wasn't actually required in branch 2.0 because Wrench did not usesocket_*
functions at the time, onlystream_socket_*
functions, which are "an integral part of PHP as of version 4.3.0."[See this article about the difference between the two]
Looking for the use of
socket_*
functions in master branch, it looks like there is only a few of them:Wrench/lib/Socket/ServerSocket.php
Line 64 in 3b82fe1
Wrench/lib/Socket/ServerSocket.php
Line 67 in 3b82fe1
Wrench/lib/Socket/Socket.php
Line 156 in 3b82fe1
Wrench/lib/Socket/Socket.php
Line 158 in 3b82fe1
So the functions concerned would be:
socket_strerror
,socket_last_error
,socket_set_option
andsocket_import_stream
.I’m not sure if there is a way to get rid of this dependency on the Sockets extension, but it would make the library easier to adopt by more people.
The text was updated successfully, but these errors were encountered: