New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme switcher bug related to mac default color scheme #9

Open

verget opened this issue Jan 13, 2020 · 0 comments

verget commented Jan 13, 2020

There is still a visual bug with a theme switcher:

First case:

MacOS user has a dark theme
It's the first load ('theme' param in localStorage does not exist)
Result:
The site loaded with a correct color theme but switcher itself in a wrong position ( screenshot attached )

Second case:

MacOS user is changing his OS theme with site opened in browser
Result:
The site's color theme doesn't follow the OS theme changing.

PR is coming =)

verget mentioned this issue

Fix visual bug related to macOS color theme #10

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment