Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if condition for actions. #914

Closed
BoPeng opened this issue Mar 7, 2018 · 3 comments
Closed

if condition for actions. #914

BoPeng opened this issue Mar 7, 2018 · 3 comments

Comments

@BoPeng
Copy link
Contributor

BoPeng commented Mar 7, 2018

We will have to use non-script format of actions if the actions are executed conditionally, something like:

if condition:
    sh(script)

I am wondering if we can provide something like

sh: skip=not condition
   script

so that we can use script format of actions even under conditions.

@gaow
Copy link
Member

gaow commented Mar 7, 2018

But we have active already. Is there a way to merge / enhance these options?

@BoPeng
Copy link
Contributor Author

BoPeng commented Mar 7, 2018

Good point. Active accepts internet, slice etc, and we can let it accept Boolean.

@BoPeng
Copy link
Contributor Author

BoPeng commented Mar 7, 2018

Done, my SoS script will look a bit better with this feature.

@BoPeng BoPeng closed this as completed Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants