Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task specific signature mode. #1000

Closed
BoPeng opened this issue Jul 20, 2018 · 3 comments
Closed

Task specific signature mode. #1000

BoPeng opened this issue Jul 20, 2018 · 3 comments

Comments

@BoPeng
Copy link
Contributor

BoPeng commented Jul 20, 2018

Right now, the tasks inherit signature mode from the sos instance. Even for PBS task engine, the signature mode is passed to the template and to the sos execute command.

I am wondering if there are cases that we want to keep signatures for main sos workflow, but use different signature mode for the tasks (something like task: sig_mode='ignore'). For example, the cluster might not like the multiple small files created by signatures (#991) and there is no need for signatures for large number of small tasks, or for production runs.

@gaow
Copy link
Member

gaow commented Jul 20, 2018

🥇 for the 1000^{th} issue ...

For example, the cluster might not like the multiple small files created by signatures (#991) and there is no need for signatures for large number of small tasks, or for production runs.

Sure that'd be very helpful! But how to prevent rerun / or trigger rerun in this case? Use some local .sos signatures?

@BoPeng
Copy link
Contributor Author

BoPeng commented Jul 20, 2018

Do not know. Need to think harder.

@BoPeng
Copy link
Contributor Author

BoPeng commented Jul 26, 2018

With the new .task file format, tasks store signatures within the completed .task file. There is therefore no longer a concern on small signature files. The only use of

task: sig_mode='ignore'

would be skipping the calculation of md5 of input and output files, at the cost of not able to skip a task, which is not important for production runs. However, I would argue in the later case a workflow level -s ignore would suffice so there is no need for task-specific signature mode.

So I think this will be WONTFIX unless there is another strong argument for it.

@BoPeng BoPeng closed this as completed Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants