Either.mapLeft Javadoc seems incorrect

[asarkar]

v2.0.4 Either.mapLeft says:

default Either<U,R> mapLeft(Function<? super L,? extends U> leftMapper)
Maps this right-biased Either.

Shouldn't it be "Maps this left-based Either"?

[danieldietrich]

Thank you. You are right, it is unclear. It is correct that the Either is right-biased, regardless if its left value or its right value is mapped. I will change the docs like this:

"Maps the left value of this Either, if present."

[asarkar]

@danieldietrich Thank you. I suggest that you also explicitly say "...is a no-op if the value is a Right", or something to that effect. And at the same time, a similar phrase could be added to the map too.

[danieldietrich]

Yes, the javadoc could be more mature throughout the project. We currently focus on the work of the other issues towards the bugfix release 2.0.5 and the next minor release 2.1.0.

Contributions, especially to javadoc, are welcome!

[asarkar]

I'd be happy to but do you really need contribution to add 35 characters? Perhaps 70, if map is updated as well.

[danieldietrich]

Of course not.