-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roadmap to v2 #144
Comments
Why would you want to remove the purify option? Sometimes you want to translate some HTML texts.
The default purify function html-encodes data, so it's not usable as HTML: the tags appear as text. Currently, you can use this trick to bypass it: What do you intend to do regarding those use cases? |
Hi @Gwened and thanks for taking the time for feedback! We want to remove this option, as it doesn't make sense to have all translations purified. As you said, sometimes you want to translate email templates or other potentially data-sensitive texts. In our opinion, you should sanitize (purify) the text explicitly, in your code, according to your own rules and requirements. If you need one, I strongly recommend the Additionally, our current implementation yields unnecessary performance impacts that could be avoided. |
Thanks, makes sense. |
Hi, I can see there's a Readme for v2 somewhere, but I'm unable to access it. Can you possibly make this public? |
Hi @jasongrishkoff, Readme was changed a little, but it is still available on the main page of the Github repo. Are you looking for something specific? |
From what I can see, one of the main changes is that you've removed |
|
Okay great. And the issue with |
What issue are you referring to? Can you send me a link? |
Sorry for the confusion. It was this comment: https://forums.meteor.com/t/what-are-currently-the-most-optimal-i18n-tools/57865/6 |
We described several ways to integrate this package with React. There is an approach with the meteor's |
2.0 RC1 does not work and the build process crashes with |
Hi @dovydaskukalis, thanks for your feedback. I fixed that in |
|
This issue will be updated later.
Our main goal is to make the package lighter, more configurable, and easier to debug.
getRefreshMixin
). The important part here is to create a guide on using the package with React.createTranslator
andcreateReactiveTranslator
and create a short note on how to replace it.purify
option.parseNumber
.getTranslation
fallbacking mechanism.hideMissing
option.getTranslation
.Intl
API?The text was updated successfully, but these errors were encountered: