Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added explicit form type casting. #1003

Merged
merged 8 commits into from
Sep 13, 2021
Merged

Added explicit form type casting. #1003

merged 8 commits into from
Sep 13, 2021

Conversation

wadamek65
Copy link
Contributor

@wadamek65 wadamek65 commented Aug 24, 2021

This PR introduces casting of all form types explicitly across all themes where previously they were typed as any due to TS constraints.

@codecov
Copy link

codecov bot commented Aug 24, 2021

Codecov Report

Merging #1003 (f10491d) into master (8dd2d74) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1003   +/-   ##
=======================================
  Coverage   98.98%   98.98%           
=======================================
  Files         202      202           
  Lines        3150     3150           
  Branches      796      796           
=======================================
  Hits         3118     3118           
  Partials       32       32           
Impacted Files Coverage Δ
packages/uniforms-antd/src/AutoForm.tsx 100.00% <100.00%> (ø)
packages/uniforms-antd/src/BaseForm.tsx 100.00% <100.00%> (ø)
packages/uniforms-antd/src/QuickForm.tsx 100.00% <100.00%> (ø)
packages/uniforms-antd/src/ValidatedForm.tsx 100.00% <100.00%> (ø)
packages/uniforms-bootstrap3/src/AutoForm.tsx 100.00% <100.00%> (ø)
packages/uniforms-bootstrap3/src/BaseForm.tsx 100.00% <100.00%> (ø)
packages/uniforms-bootstrap3/src/QuickForm.tsx 100.00% <100.00%> (ø)
packages/uniforms-bootstrap3/src/ValidatedForm.tsx 100.00% <100.00%> (ø)
packages/uniforms-bootstrap4/src/AutoForm.tsx 100.00% <100.00%> (ø)
packages/uniforms-bootstrap4/src/BaseForm.tsx 100.00% <100.00%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dd2d74...f10491d. Read the comment docs.

@wadamek65 wadamek65 marked this pull request as ready for review August 24, 2021 15:00
@wadamek65 wadamek65 requested a review from radekmie as a code owner August 24, 2021 15:00
@wadamek65 wadamek65 self-assigned this Aug 25, 2021
@wadamek65 wadamek65 added the Type: Feature New features and feature requests label Aug 25, 2021
radekmie
radekmie previously approved these changes Aug 25, 2021
Copy link
Contributor

@radekmie radekmie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is definitely better than it was now. However, we'd need to prepare solid and clear documentation of the change, including workarounds (if needed).

@wadamek65
Copy link
Contributor Author

@radekmie I'd be happy to add the documentation within this PR if you could provide a little more details on where it should be.

@radekmie
Copy link
Contributor

  1. A short comment for the CHANGELOG.md about this change in general.
  2. A note in the FAQ section, on what to do when these typings actually broke somebody's code (i.e., cast to any and report us a bug).

Monteth
Monteth previously approved these changes Aug 31, 2021
@wadamek65 wadamek65 dismissed stale reviews from Monteth and radekmie via f10491d August 31, 2021 11:46
@wadamek65
Copy link
Contributor Author

@radekmie I've added some docs in the FAQ section. I suppose it will be a good basis for when the changelog is actually created or should I also prepare this and put it somewhere right now?

@wadamek65 wadamek65 requested a review from radekmie August 31, 2021 11:47
@radekmie radekmie merged commit 91dd6ed into master Sep 13, 2021
@radekmie radekmie deleted the autoform-types branch September 13, 2021 20:55
@radekmie radekmie added this to the v3.6 milestone Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New features and feature requests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants