-
-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added explicit form type casting. #1003
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1003 +/- ##
=======================================
Coverage 98.98% 98.98%
=======================================
Files 202 202
Lines 3150 3150
Branches 796 796
=======================================
Hits 3118 3118
Partials 32 32
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is definitely better than it was now. However, we'd need to prepare solid and clear documentation of the change, including workarounds (if needed).
@radekmie I'd be happy to add the documentation within this PR if you could provide a little more details on where it should be. |
|
@radekmie I've added some docs in the FAQ section. I suppose it will be a good basis for when the changelog is actually created or should I also prepare this and put it somewhere right now? |
This PR introduces casting of all form types explicitly across all themes where previously they were typed as any due to TS constraints.