Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed BoolField label in uniforms-semantic. #1042

Merged
merged 1 commit into from
Oct 8, 2021

Conversation

radekmie
Copy link
Contributor

@radekmie radekmie commented Oct 6, 2021

In this PR I fixed the presence of the checkbox in BoolField of uniforms-semantic as it wasn't there if the field had no label.

@radekmie radekmie added the Type: Bug Bug reports and their fixes label Oct 6, 2021
@radekmie radekmie added this to the v3.6 milestone Oct 6, 2021
@codecov
Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #1042 (ca7cbe7) into master (a36891a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1042   +/-   ##
=======================================
  Coverage   98.59%   98.59%           
=======================================
  Files         202      202           
  Lines        3207     3207           
  Branches      826      826           
=======================================
  Hits         3162     3162           
  Partials       45       45           
Impacted Files Coverage Δ
packages/uniforms-semantic/src/BoolField.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a36891a...ca7cbe7. Read the comment docs.

@radekmie radekmie merged commit 144a7ee into master Oct 8, 2021
@radekmie radekmie deleted the fixed-boolfield-label-semantic branch October 8, 2021 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Bug reports and their fixes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants