added checkbox option for BoolField for antd #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #348 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 156 156
Lines 1305 1305
=====================================
Hits 1305 1305
Continue to review full report at Codecov.
|
radekmie
suggested changes
Sep 26, 2017
| @@ -1,83 +1,155 @@ | |||
| import React from 'react'; | |||
| import Switch from 'antd/lib/switch'; | |||
| import Checkbox from 'antd/lib/checkbox'; | |||
| import {mount} from 'enzyme'; | |||
| @@ -1,26 +1,38 @@ | |||
| import Icon from 'antd/lib/icon'; | |||
| import React from 'react'; | |||
| import Switch from 'antd/lib/switch'; | |||
| import Checkbox from 'antd/lib/checkbox'; | |||
| import connectField from 'uniforms/connectField'; | |||
| import filterDOMProps from 'uniforms/filterDOMProps'; | |||
There was a problem hiding this comment.
These should stay in order.
| onChange={() => props.onChange(!props.value)} | ||
| ref={props.inputRef} | ||
| {...filterDOMProps(props)} | ||
| /> |
There was a problem hiding this comment.
How about React.createElement(props.checkbox ? Checkbox : Switch, {...})? It'll reduce this duplicated code.
| @@ -2,6 +2,7 @@ const unwantedProps = [ | |||
| // These props are provided by BaseField | |||
| 'changed', | |||
| 'changedMap', | |||
| 'checkbox', | |||
There was a problem hiding this comment.
These are global, so it's a breaking change. I'd rather go with destructuring props in BoolField - it won't be needed then.
|
Thanks for feedback, learning something new every day. |
radekmie
approved these changes
Sep 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds ability to create an antd
Checkboxwith uniformsBoolFieldinstead of just the antdSwitch.Usage