Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to support Antd v3.0 #372

Closed
corymsmith opened this issue Dec 6, 2017 · 7 comments
Closed

Update to support Antd v3.0 #372

corymsmith opened this issue Dec 6, 2017 · 7 comments
Assignees
Labels
Type: Feature New features and feature requests

Comments

@corymsmith
Copy link

Antd 3.0 was just released a couple days ago: https://ant.design/changelog#3.0.0

@radekmie radekmie self-assigned this Dec 6, 2017
@radekmie radekmie added the Type: Feature New features and feature requests label Dec 6, 2017
@radekmie
Copy link
Contributor

radekmie commented Dec 6, 2017

Hello @corymsmith!

It looks like no big (very big) changes were made. Have you tried it already with uniforms-antd?

cc: @Gervwyk

@corymsmith
Copy link
Author

Had some warnings around peerDependencies since its 2.x but then didn't have time to fully test it out unfortunately.

@radekmie
Copy link
Contributor

radekmie commented Dec 7, 2017

Would you? It would be great to see, if the only problem is the version constraint.

@Gervwyk
Copy link
Contributor

Gervwyk commented Dec 8, 2017

I'll also try updating over the weekend or definitely next week. Will let you know if all goes well.

@Gervwyk
Copy link
Contributor

Gervwyk commented Dec 13, 2017

I've tested and all looks well thus far, a few major changes so its definitely a breaking change if you use card and table (might not be a breaking change in form context - will investigate).
Except for importing into meteor. https://forums.meteor.com/t/antd-3-0-is-out/40926/13?u=mrmsupport
I'll recommend waiting from meteor 1.6.1 to fix bug before updating. I'll also continue with testing after 1.6.1. If someone want to try on beta in the mean time, that would be great. I'll have time for it in a week or two, by which 1.6.1 is hopefully up.

@radekmie
Copy link
Contributor

Well, the only problem I found was this:

🗑 Input's type prop has dropped textarea support, please use Input.TextArea instead.

It's included in v1.23.0-rc.1. Check it out and let me know if everything is OK.

@pozylon
Copy link

pozylon commented Jan 10, 2018

I just tested rc.1 with antd 3.1.1 on a fairly complex form, no issues since.

@radekmie radekmie moved this to Closed in Open Source Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New features and feature requests
Projects
Archived in project
Development

No branches or pull requests

4 participants