Pass labelProps to DateField and SelectField #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #485 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 157 157
Lines 1401 1401
=====================================
Hits 1401 1401
Continue to review full report at Codecov.
|
radekmie
suggested changes
Nov 12, 2018
| @@ -43,6 +43,7 @@ const renderSelect = ({ | |||
| showInlineError, | |||
| transform, | |||
| value, | |||
| labelProps, | |||
There was a problem hiding this comment.
Please keep these ordered.
API.md
Outdated
| @@ -1,5 +1,6 @@ | |||
| # Table of Contents | |||
|
|
|||
| - [Table of Contents](#table-of-contents) | |||
There was a problem hiding this comment.
It's a good addition. Leave it as it is now, but it's better not to mix purposes of PR.
There was a problem hiding this comment.
Oh, vscode did this automatically, didn't mean to do that.
|
Should be ok. |
radekmie
approved these changes
Nov 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #481.
It turns out there was only
DateFieldandSelectFieldthat can use the extralabelProps. TheTextFieldcomponent, used in most places, can already get aInputLabelPropsprop that will be passed to itsInputLabel.For the sake of consistency, I changed the
FormLabeltoInputLabelonDateField, as I don't think it is required. I'll revert it if there was a specific reason behind it.