Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for label classes #548

Merged
merged 5 commits into from
Jul 9, 2019
Merged

Add support for label classes #548

merged 5 commits into from
Jul 9, 2019

Conversation

chirvo
Copy link
Contributor

@chirvo chirvo commented Jul 2, 2019

For being able to alter the looks of the label without depending on 'grid'.

For being able to alter the looks of the label without depending on 'grid'.
@chirvo chirvo requested a review from radekmie as a code owner July 2, 2019 09:28
@codecov
Copy link

codecov bot commented Jul 2, 2019

Codecov Report

Merging #548 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #548   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         162    162           
  Lines        1570   1570           
=====================================
  Hits         1570   1570
Impacted Files Coverage Δ
packages/uniforms-bootstrap3/src/wrapField.js 100% <ø> (ø) ⬆️
packages/uniforms-bootstrap4/src/wrapField.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7850502...2b699f0. Read the comment docs.

@radekmie radekmie added the Type: Feature New features and feature requests label Jul 2, 2019
@radekmie
Copy link
Contributor

radekmie commented Jul 2, 2019

Hi @bigchirv. Really small change looks good (docs!). Can you add it to the bootstrap3 theme too? A simple test would also be great.

@chirvo
Copy link
Contributor Author

chirvo commented Jul 6, 2019

Thanks for pointing out writing the tests, really forgot about them. 😃

On what file should I add the documentation on the labelClassName prop for bootstrap 3/4?

@radekmie
Copy link
Contributor

radekmie commented Jul 8, 2019

It should be in docs/api-fields.md.

@chirvo
Copy link
Contributor Author

chirvo commented Jul 9, 2019

Okay, I added the entries in api-fields.md as suggested.

@radekmie radekmie merged commit 807bcaf into vazco:master Jul 9, 2019
@radekmie
Copy link
Contributor

radekmie commented Jul 9, 2019

Thank you @bigchirv!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New features and feature requests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants