-
-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ListField with reordering and better buttons look (Material-UI) #651
Comments
Hi there, @chomamateusz. It sounds promising! I just can't access the demo right now - it's loading indefinitely or displaying random errors. I'll try again later (or in a different browser), but could you post here a few screenshots of it? Preferably with both simple items, like |
Ow, the demo is failing in my browser now too :/ think it may be connected with #638 or just the in browser bundlers aren't perfect ;) Old-fashioned demo: Added nested arrays. What do you mean to use |
Cool, now I can finally play with it! Looks good for me, but I'd have to ask a few people actually using the current one if they like it as well. If so, we could include it in the v3. |
Cool :) It's now quite simple field, built in moment of need when developing bigger project. I've built once a field generator like Uniforms (but Uniforms are more unified, so I started using it), and in my generator I had a more flexible field with e.g. collapsing possibilities. Drag and drop would be nice. I will probably continue to develop this field. I also have now monaco editor field also I think is too specified to include in Uniforms package, right? It is possible that v3 will be released as you said "The first version should be released by the end of November 2019."? |
Sure, that's normal. It's nice though!
Yep, it's too tied with it and not really in align with any theme package. You can release it by yourself as well.
I'll try to squeeze it this week. Is 1st of December valid? 😆 Anyway, consider is as a real alpha version and there's no need to rush with bundling this field. |
Hey @chomamateusz this looks awesome. I was having a similar thought about the material UI integration. |
Hey @lightningboss. Well, there's nothing to do, but if you'll make something you think more people would like - just open an issue to discuss or even file a PR. When it comes to this very |
We've discussed this and due to cross-theme compatibility reasons (all themes would need to implement reordering) we've decided not to do it. However, once #640 land, it'll be fairly easy to swap certain fields to their custom counterparts. |
Hi!
I've recently written a component that adds reordering items to ListField and improves look of buttons (IconButon with fullWidth is not good-looking in my opinion :)).
It is written only for Material-UI, so I didn't do a PR. Maybe I should? If so - as a new component or modifying ListField?
Check it out here (code and demo) -> https://bit.dev/amazingdesign/uniforms/list-field-reorder
I am quite new to this project, so I hope to hear feedback about my modifications :)
The text was updated successfully, but these errors were encountered: