-
-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added kind option to connectField. #741
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v3 #741 +/- ##
=======================================
Coverage 97.87% 97.87%
=======================================
Files 175 175
Lines 3429 3435 +6
Branches 625 637 +12
=======================================
+ Hits 3356 3362 +6
Misses 8 8
Partials 65 65
Continue to review full report at Codecov.
|
Monteth
force-pushed
the
v3-connectfield-kind
branch
from
June 17, 2020 10:55
01dc4ef
to
325b96e
Compare
Monteth
approved these changes
Jun 17, 2020
kestarumper
reviewed
Jun 17, 2020
kestarumper
approved these changes
Jun 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a
kind: 'leaf' | 'node'
flag for theconnectField
, closing #717. This information is later used byAutoField
, allowing it to skip one components layer (namely,Field
created inconnectField
), effectively getting rid of oneuseField
per field.Rendering time (see #716) reduced noticeably, especially the upper bounds:
This is still a proof of concept, though. Things that are left:
Decide ifWe'll introduce it as an internal API, therefore it could be changed without a major version change. In the following v3.x versions it may become public (and obtain stability guarantees).Component
andoptions
are part of the public API.Decide ifWe'll stick tokind
is a good name and way of specifying that. Maybe something more specific likemayHaveSubfield
,isLeaf
orplainField
would make more sense.kind
for now.kind: 'leaf'
whenever possible.